Avoid collecting associated types for undefined trait #137631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @compiler-errors. Use |
rustbot
added
S-waiting-on-review
|
HIR ty lowering was modified cc @fmease |
TaKO8Ki
force-pushed
the
issue-137508
branch
from
45e148a to
1ac2051
Compare
compiler-errors
requested changes
Feb 25, 2025
| } | ||
|
|
||
| fn main() { | ||
| let _: dyn Tr + ?Foo(); |
There was a problem hiding this comment.
This doesn't have to do with parenthesized syntax. This also ICEs: + ?Foo<Assoc = ()>.
Please edit the test name so it's more clear what it's testing, add the issue number as a comment like:
// Fix for <https://github.com/issues....>
There was a problem hiding this comment.
Sorry, I forgot to mention explicitly:
Change the test to use + ?Foo<Assoc = ()> rather than the parentheses syntax.
| trait_def, | ||
| ); | ||
| let trait_def = path.res.opt_def_id(); | ||
| let assoc_item = trait_def.and_then(|trait_def_id| { |
There was a problem hiding this comment.
Please leave a comment here saying that we don't want to unwrap a trait def id if it resolves incorrectly.
rustbot
added
S-waiting-on-author
|
Actually, #137554 is the same issue, but with a different kind of item. Instead of calling |
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-review
compiler-errors
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Add a test for #137554, and squash this into one commit.
Also no need to click the "request review" button; I'll review the PR when I have free time. All it does is give me an unnecessary notification.
| let _: dyn Tr + ?Foo<Assoc = ()>; | ||
| //~^ ERROR: `?Trait` is not permitted in trait object types | ||
| //~| ERROR: cannot find trait `Foo` in this scope | ||
| //~| ERROR: the value of the associated type `Item` in `Tr` must be specifi |
There was a problem hiding this comment.
Suggested change
| //~| ERROR: the value of the associated type `Item` in `Tr` must be specifi | |
| //~| ERROR: the value of the associated type `Item` in `Tr` must be specified |
rustbot
added
S-waiting-on-author
rename ui tests check if res is trait def fix typo regression test for rust-lang#137554
TaKO8Ki
force-pushed
the
issue-137508
branch
from
4a77dae to
b7a5497
Compare
compiler-errors
approved these changes
Feb 25, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
Feb 26, 2025
…rrors Avoid collecting associated types for undefined trait Fixes rust-lang#137508 Fixes rust-lang#137554
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup of 10 pull requests Successful merges: - rust-lang#134585 (remove `MaybeUninit::uninit_array`) - rust-lang#136187 (Use less CString in the examples of CStr.) - rust-lang#136457 (Expose algebraic floating point intrinsics) - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`) - rust-lang#137620 (Fix `attr` cast for espidf) - rust-lang#137631 (Avoid collecting associated types for undefined trait) - rust-lang#137635 (Don't suggest constraining unstable associated types) - rust-lang#137642 (Rustc dev guide subtree update) - rust-lang#137660 (Update gcc submodule) - rust-lang#137670 (revert accidental change in get_closest_merge_commit) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup of 10 pull requests Successful merges: - rust-lang#134585 (remove `MaybeUninit::uninit_array`) - rust-lang#136187 (Use less CString in the examples of CStr.) - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`) - rust-lang#137620 (Fix `attr` cast for espidf) - rust-lang#137631 (Avoid collecting associated types for undefined trait) - rust-lang#137635 (Don't suggest constraining unstable associated types) - rust-lang#137642 (Rustc dev guide subtree update) - rust-lang#137660 (Update gcc submodule) - rust-lang#137670 (revert accidental change in get_closest_merge_commit) - rust-lang#137671 (Make -Z unpretty=mir suggest -Z dump-mir as well for discoverability) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup merge of rust-lang#137631 - TaKO8Ki:issue-137508, r=compiler-errors Avoid collecting associated types for undefined trait Fixes rust-lang#137508 Fixes rust-lang#137554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137508
Fixes #137554